Re: Documentation for chdb extension
| From: | Philip Olson | Date: | Thu, 17 Jun 2010 16:30:46 +0000 |
| Subject: | Re: Documentation for chdb extension | ||
| References: | 1 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969381957@lists.php.net to get a copy of this message | ||
On Jun 17, 2010, at 7:57 AM, Lorenzo Castelli wrote:
> Hi,
>
> I recently created a new extension on PECL called chdb, and I would like
> to commit the corresponding documentation.
>
> This would be my first contribution to the PHP documentation, and I lack
> phpdoc karma.
>
> You can find the two patches to 'doc-base' and 'en' attached.
Greetings Lorenzo,
Looks good, and you now have the karma to commit. Welcome to the PHP Documentation team :)
A few minor issues that come to mind:
- The phrase "providing the perfect hashing function" ... perfect? ;)
- Lack of versions within versions.xml
Regards,
Philip