Re: Documentation for chdb extension

On Thu, Jun 17, 2010 at 18:30, Philip Olson <philip@roshambo.org> wrote: > > On Jun 17, 2010, at 7:57 AM, Lorenzo Castelli wrote: > >> Hi, >> >> I recently created a new extension on PECL called chdb, and I would like >> to commit the corresponding documentation. >> >> This would be my first contribution to the PHP documentation, and I lack >> phpdoc karma. >> >> You can find the two patches to 'doc-base' and 'en' attached. > > Greetings Lorenzo, > > Looks good, and you now have the karma to commit. Welcome to the PHP Documentation team :) > > A few minor issues that come to mind: > >  - The phrase "providing the perfect hashing function" ... perfect? ;) In computer science, perfect hashing is a technique that provides worst-case O(1) lookups on a hash table. For this to be possible, it's a specific requirement that the data doesn't change, however. It's standard terminology as far as I know. >  - Lack of versions within versions.xml > > Regards, > Philip > > -- Daniel Egeberg