Re: xml functions
| From: | Hannes Magnússon | Date: | Mon, 06 Dec 2010 14:06:35 +0000 |
| Subject: | Re: xml functions | ||
| References: | 1 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969382337@lists.php.net to get a copy of this message | ||
2010/12/5 Carlos Hernández <carlos@php.net>:
> Hi!
>
> I've added description for: $parser, $prefix, $uri, and other attributes in these xml
> functions. I've saved as patches for review, and I've reported 2 bugs in:
>
> xml-set-start-namespace-decl-handler and xml-set-end-namespace-decl-handler
>
>
> but I can't to commit the files because I don't have enough karma. I'd like if
> anyone would can to review it, thank you very much :)
Looks good to me.
There are several unrelated WS changes in there though..
Btw; to create a proper patch;
$ cd doc-en
$ svn diff reference/xml > mypatch.patch
:)
Philip; Bump his karma?
-Hannes