Re: xml functions

On Dec 6, 2010, at 6:06 AM, Hannes Magnússon wrote: > 2010/12/5 Carlos Hernández <carlos@php.net>: >> Hi! >> >> I've added description for: $parser, $prefix, $uri, and other attributes in these xml >> functions. I've saved as patches for review, and I've reported 2 bugs in: >> >> xml-set-start-namespace-decl-handler and xml-set-end-namespace-decl-handler >> >> >> but I can't to commit the files because I don't have enough karma. I'd like >> if anyone would can to review it, thank you very much :) > > > Looks good to me. > There are several unrelated WS changes in there though.. > > Btw; to create a proper patch; > $ cd doc-en > $ svn diff reference/xml > mypatch.patch > > :) > > Philip; Bump his karma? Sounds good. Karma for Braian (x1v4nx) and Carlos (carlos) have been updated to include all that is PHP doc related. Great! :) Regards, Philip