Re: Patch to Add AMQP Examples
| From: | Philip Olson | Date: | Fri, 26 Aug 2011 00:35:08 +0000 |
| Subject: | Re: Patch to Add AMQP Examples | ||
| References: | 1 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969383123@lists.php.net to get a copy of this message | ||
On Aug 25, 2011, at 11:14 AM, Bradley Holt wrote:
> Hi,
>
> Attached is a patch to add examples to the documentation for
> AMQPQueue::get and AMQPQueue::ack.
Hello Bradley,
Looks good. A few minor issues:
- Use <methodname> for all methods. Sometimes you used <function>.
Both work but, well, I did say "minor" issues :)
- PHP code indentation should be 4 spaces instead of the XML
friendly 1
Also, your SVN account request has been approved with phpdoc karma
granted, welcome to the PHP Documentation team! :)
Regards,
Philip