Re: Patch to Add AMQP Examples

From: Date: Fri, 26 Aug 2011 16:11:32 +0000
Subject: Re: Patch to Add AMQP Examples
References: 1 2 3  Groups: php.doc 
Request: Send a blank email to phpdoc+get-969383125@lists.php.net to get a copy of this message
On 26 August 2011 17:05, Bradley Holt <bradley.holt@foundline.com> wrote: > Philip, > > On Thu, Aug 25, 2011 at 8:35 PM, Philip Olson <philip@roshambo.org> wrote: >> >> On Aug 25, 2011, at 11:14 AM, Bradley Holt wrote: >> >>> Hi, >>> >>> Attached is a patch to add examples to the documentation for >>> AMQPQueue::get and AMQPQueue::ack. >> >> >> Hello Bradley, >> >> Looks good. A few minor issues: >> >>  - Use <methodname> for all methods. Sometimes you used <function>. >>   Both work but, well, I did say "minor" issues :) >>  - PHP code indentation should be 4 spaces instead of the XML >>   friendly 1 >> > > Got it. I was following the examples set elsewhere in AMQP > documentation. I guess updating those to follow the proper standard is > another task that could be done :-) Absolutely. :) > >> Also, your SVN account request has been approved with phpdoc karma >> granted, welcome to the PHP Documentation team! :) >> > > Woo-hoo! > > Should I apply these last couple of patches that I've sent in, now > that I've got commit access? Yes! That's what the karma is there for. Any questions just ask, here or on IRC. Welcome to the documentation team! > > Thanks, > Bradley > >> Regards, >> Philip >> >> >> >

« previous php.doc (#969383125) next »