Re: The commit
| From: | Simion Onea | Date: | Fri, 05 Sep 2014 21:43:25 +0000 |
| Subject: | Re: The commit | ||
| References: | 1 2 3 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969385145@lists.php.net to get a copy of this message | ||
On Sat, Sep 6, 2014 at 12:40 AM, Simion Onea <simionea@gmail.com> wrote:
> On Fri, Sep 5, 2014 at 7:13 PM, Peter Cowburn <petercowburn@gmail.com>
> wrote:
>
>> Hi Simion et al,
>>
>> I don't have anything much to add to this thread, other than what has
>> already been expressed. The only thing I would say is, if anyone reading
>> this is ever thinking about touching a lot of files like this, or some
>> other batch change, then:
>>
>> **Please discuss on the list first.**
>>
>> Wide-reaching changes have wide-reaching effects, for the most part, and
>> are not something to be done on a whim.
>>
>> Cheers,
>> Peter
>>
>>
> I have corrected and committed all the affected files in the translations.
> The steps I took:
> 1. I determined the list of the files affected by the initial commit.
> 2. For each file I found what was the previous revision number (before my
> commit).
> 3. I checked all the translations for the presence of the affected files.
> 4. If the file was found and it's "EN-Revision" was equal to the English
> file revision before my commit, I updated the EN-Revision to the number
> after my commit (334762).
> 5. I committed all changed files.
>
> The results are as follows:
> My initial commit affected 831 files.
> Affected files in translations:
> - 1 files in 'da'
> - 14 files in 'de'
> - 613 files in 'es'
> - 30 files in 'fa'
> - 642 files in 'fr'
> - 7 files in 'it'
> - 627 files in 'ja'
> - 1 files in 'kr'
> - 36 files in 'pl'
> - 6 files in 'pt_BR'
> - 224 files in 'ru'
> - 1 files in 'sr'
> - 13 files in 'tr'
> - 1 files in 'tw'
> - 35 files in 'zh'
>
> The good thing is that the problem was not so dramatic as Maciej
> predicted. And hopefully I corrected all the harm that has been done.
> Nevertheless I now realize that I shouldn't have done such a massive
> change.
> I apoligize again. And please let me know if I missed something and there
> is something more to be corrected.
>
> Sincerely,
> Simion.
>
I forgot to mention that the XML definitions of the affected files were
updated as well.