Re: Contribution: opcache_is_script_cached
| From: | Peter Cowburn | Date: | Wed, 11 Feb 2015 09:41:58 +0000 |
| Subject: | Re: Contribution: opcache_is_script_cached | ||
| References: | 1 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969385350@lists.php.net to get a copy of this message | ||
Hi Trevor,
On 11 February 2015 at 07:05, Trevor Suarez <rican7@gmail.com> wrote:
> Hello PHP documentation team,
>
> I've made my first PHP documentation contribution. There was a new
>
opcache_is_script_cached() function added in PHP 5.6, but a
> proper
> documentation page was never added in the manual. I've made a first attempt
> at a basic page for the new function. I hope its sufficient, at least to
> start.
>
> The new patch can be found here:
> https://edit.php.net/?patchID=1458&project=PHP
>
Fantastic! That patch looked basically ready-to-go, so I've gone ahead and
committed it for you. [1]
> Please let me know if there's anything I did incorrectly.
>
The only thing that you forgot, or didn't know, to do was edit the
versions.xml file in the opcache folder, to add in the version information
for this function. I included this change in the commit as well.
>
>
Thanks!
>
Thank you!
>
>
> - Trevor Suarez
>
Regards,
Peter
[1] http://svn.php.net/viewvc?view=revision&revision=335912