Re: Contribution: opcache_is_script_cached

> > Fantastic! That patch looked basically ready-to-go, so I've gone ahead > and committed it for you. > Oh awesome! Thank you so much for committing it. The only thing that you forgot, or didn't know, to do was edit the > versions.xml file in the opcache folder, to add in the version information > for this function. I included this change in the commit as well. > Ah, ok, I was wondering where that information was pulled from. I'll have to remember that for future edits/additions. Thank you! > I'm happy to be a part. :) - Trevor Suarez On Wed, Feb 11, 2015 at 4:41 AM, Peter Cowburn <petercowburn@gmail.com> wrote: > Hi Trevor, > > On 11 February 2015 at 07:05, Trevor Suarez <rican7@gmail.com> wrote: > >> Hello PHP documentation team, >> >> I've made my first PHP documentation contribution. There was a new >> opcache_is_script_cached() function added in PHP 5.6, but a >> proper >> documentation page was never added in the manual. I've made a first attempt >> at a basic page for the new function. I hope its sufficient, at least to >> start. >> >> The new patch can be found here: >> https://edit.php.net/?patchID=1458&project=PHP >> > > Fantastic! That patch looked basically ready-to-go, so I've gone ahead > and committed it for you. [1] > > >> Please let me know if there's anything I did incorrectly. >> > > The only thing that you forgot, or didn't know, to do was edit the > versions.xml file in the opcache folder, to add in the version information > for this function. I included this change in the commit as well. > > >> >> > Thanks! >> > > Thank you! > >> >> >> - Trevor Suarez >> > > Regards, > > Peter > > [1] http://svn.php.net/viewvc?view=revision&revision=335912 >