Re: PHP 7.2 Migration Guide

First off, thanks everyone for putting in the efforts thus far on the 7.2 migration guide. It looks like we'll have a good chunk of it ready before the release announcement. On 28 November 2017 at 23:32, Christoph M. Becker <cmbecker69@gmx.de> wrote: > On 28.11.2017 at 18:13, Kalle Sommer Nielsen wrote: > > > Thanks for the work you put into the guide, our biggest task is by far > > Sodium /o\ > > I've ran docgen -e sodium, and the results are as good as > expected, > except that all return types are given as ReturnType and all > parameter > types are string. I don't have the time to fill in the > details > (particularly, since ext/sodium has no "protos" or other comprehensive > documentation, and there are 73 functions), and unless somebody else is > going to tackle this task, I would suggest to commit the results. > However, in my opinion documenting unknown types as string is a bad > idea, so it might be best to document the unknown types as ÔC > Óè‚K¶…rÄqi‘þ+unknown or > ?, or to omit them altogether. > > Thoughts? > I'm happy if you just commit the skeleton docs as-is, even if the prototypes are wrong / incomplete. We can iteratively improve the docs once the skeletons are there. > > -- > Christoph M. Becker >