Re: Should I document session_get_cookie_params => setcookie?
| From: | Peter Cowburn | Date: | Tue, 02 Jun 2020 07:35:05 +0000 |
| Subject: | Re: Should I document session_get_cookie_params => setcookie? | ||
| References: | 1 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969387538@lists.php.net to get a copy of this message | ||
On Tue, 2 Jun 2020 at 02:58, Karoly Negyesi <karoly@negyesi.net> wrote:
> Hello,
>
> Today I wanted to check from JavaScript whether a session was started but
> the system sets the session cookie to httponly so I can't do that so I
> wanted to do setcookie('has_session', 1, session_get_cookie_params()). This
> of course (?) doesn't work. Should I add a code snippet on how to make it
> work to session_get_cookie_params and / or setcookie or should I just
> submit to Stackoverflow as a self answer?
>
Probably the latter.
> I already added
> https://marc.info/?l=php-doc-cvs&m=159105012229429&w=2
> because that's generic enough. Speaking of, should I amend the return
> values of setcookie to include this null or just this commit is enough?
>
I'm not sure where the null is coming from. The function should be
returning false for the case you've described, right?
>
> Best,
>
> NK
>
>