Re: Should I document session_get_cookie_params => setcookie?

OK, thanks, I removed the "&null; is returned" part and that's it for now. On Tue, Jun 2, 2020 at 1:28 AM Christoph M. Becker <cmbecker69@gmx.de> wrote: > On 02.06.2020 at 10:10, Karoly Negyesi wrote: > > > I need to fix that commit -- the warning is correct but the return value > > will still be TRUE, the NULL comes from something else: > > https://3v4l.org/MejIO namely, I tried to run this in PHP > > 7.2 when I > got a > > NULL. You still can easily coax a NULL return from setcookie() though: > > https://3v4l.org/CSgIB which now probably should go on the > > return value > > section. > That NULL is the "normal" return value for ZPP failures[1]; we do not > document this for every single function. In PHP 8, passing wrong > parameter types will throw an exception instead[2]. > > [1] > <https://www.php.net/manual/en/functions.internal.php> > [2] <https://3v4l.org/CSgIB/rfc#git-php-master> > > -- > Christoph M. Becker >