Re: Re[4]: How to manage github pull requests?
| From: | André L F S Bacci | Date: | Wed, 20 Jan 2021 23:11:25 +0000 |
| Subject: | Re: Re[4]: How to manage github pull requests? | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.doc |
| Request: | Send a blank email to phpdoc+get-969387800@lists.php.net to get a copy of this message | ||
On Wed, Jan 20, 2021 at 7:00 PM G. P. B. <george.banyard@gmail.com> wrote:
> [1] Remember this old fella? http://doc.php.net/tutorial/
>>
>
> https://gitlab.com/php-infrastructe/doc has my latest WIP for a
> revcheck
>
> Currently hosted on http://doc.php.gpb.moe/tools/revcheck/
> although I
> didn't setup an automatic build so it's currently outdated.
>
It appears to be working, so it's worth replacing the SVN one.
> The main issue I have is that with the migration to git some commits which
> only touched svn attributes didn't get propagated so a bunch of files are
> considered outdated although the diff is empty.
> It would be great to be able to generate patches which would adjust the
> revision number for translations.
>
I would consider this a one time thing, in the migration process. So not
worth stopping the use.
In the same vein, a separate tool for this specific case may be very useful
in translations, something like empty-diff-bumper.php.
> A secondary issue is making the diff page on git.php.net, Nikita did find
> a way to get a diff between 2 revisions just for a file (something GH
> doesn't support),
> but for some reasons the link I'm generating are a bit bogus and haven't
> had time to look into this again.
> The relevant conversation is here:
>
> https://chat.stackoverflow.com/transcript/message/51268245#51268245
>
I will read later.
But a small hosted script that extracts a possible multi file diff, and
filters one file diff from all, may be doable. Even, necessary.
There are some big, big commits, now and then, so a fickle external diff
tool is a regression that will turn these big commits into big blocking
walls of despair.
> A final thing, as I was going with a full rewite of the doc.php.net site
> so that it can be generated statically and hosted on something like GitLab
> pages it might be a bit incompatible with the current repo,
> but Sergey was working on something a bit more streamlined with less of
> the cruft.
>
I am particularly sad with the new revcheck style (multiple pages, 100%
wide tables). This may be mobile friendly, but I immensely like the old
style static one page format, to the point of running the command line
version every day (locally via cron).
Just a hint for what streamlined / cruft may mean.
André