Re: Re[4]: How to manage github pull requests?

From: Date: Tue, 02 Feb 2021 19:09:38 +0000
Subject: Re: Re[4]: How to manage github pull requests?
References: 1 2 3 4 5 6 7 8 9 10  Groups: php.doc 
Request: Send a blank email to phpdoc+get-969387834@lists.php.net to get a copy of this message
Hi George, Thank you for your hard work! Hmm... Can you check the script? After the commit "Update EN-Revision tags for new rev-check" [1], I got many diffs in my checker =( For example, English file [2] has last git id 4754397753fd79f1c846868b66a2448babab1c54, but this commit sets the id e9366ee458b2900c53a503b1ad97664e1d9a8859. The previous id was right [3]. [1] https://github.com/php/doc-ru/commit/f192aaffda43055842db90fb5e1a478c44cdbfa9 [2] https://github.com/php/doc-en/blob/master/reference/apcu/apcuiterator/key.xml [3] https://github.com/php/doc-ru/blob/3d6dff193c2bda6d1057b7392d343e9c14bbbe05/reference/apcu/apcuiterator/key.xml Or maybe I'm doing something wrong :) wbr, Sergey Panteleev On 2 Feb 2021, 04:34 +0300, G. P. B. <george.banyard@gmail.com>, wrote: > > On Wed, 20 Jan 2021 at 23:11, André L F S Bacci <andrebacci.listas@gmail.com> > > wrote: > > > > I am particularly sad with the new revcheck style (multiple pages, 100% wide > > > > tables). This may be mobile friendly, but I immensely like the old style static one page format, to > > > > the point of running the command line version every day (locally via cron). > > > > > > > > Just a hint for what streamlined / cruft may mean. > > > > > > > > André > > > > I haven't made a custom CSS, that's one of the things which should be done. > > I just linked to the current CSS files (shared.php.net/styles/doc.css) and called it job > > done for a W.I.P. and minimal working setup. > > So for all intent and purposes the styling of the website needs to actually be done. > > > > > > In other news, I've updated it once again so that the diffs are linked correctly to > > git.php.net so to only see the file diff. > > And I've also managed to automatically create a patch for empty diff between > > different revision (well at least it seems to work pretty well). > > > > The builds are also now scheduled to be run once a day and can still be found here: > > http://doc.php.gpb.moe/tools/revcheck/ > > > > > >  George P. Banyard

« previous php.doc (#969387834) next »