Re: Opinion about the using $GLOBALS directly

Zoltán Németh wrote:

2007. 12. 19, szerda keltezéssel 10.25-kor Richard Lynch ezt írta:

On Wed, December 19, 2007 10:14 am, Stut wrote:

Richard Lynch wrote:

On Wed, December 19, 2007 4:13 am, Sancar Saran wrote:

I want know to you opinions about using $GLOBALS directly. like $GLOBALS['myString'] = 'test'; $GLOBALS['myArray']['this'] = 'this'; $GLOBALS['myArray']['that'] = 'that'; $GLOBALS['myClassObj] = new SomeClass;

Don't. You are using global variables, and you might as well admit it and use the 'global' keyword to designate them as such. Poking stuff into $GLOBALS instead just makes it look like you're trying to pretend you're not using global variables when you are, to me. I did form this opinion before altering $GLOBALS was a documented feature.

I would have to disagree. Using the global keyword makes it less obvious that the variable your dealing with is in the global scope. Using $GLOBALS instead makes it clear to anyone looking at the code that you're dealing with a global variable.

Since the global keyword MEANS that the variable is in the global scope, I'm having a hard time seeing how it's less clear that the variable is in the global scope...

well, if you have a long and complex function declaration which begins with global $whatever, and then all over the function $whatever is used, some dozens of lines later when looking for something in the code you might not have any idea that $whatever is global... however if you used $GLOBALS['whatever'] everywhere it would be trivial.

Indeed. -Stut -- http://stut.net/