Re: How to get a code review?

Nathan Nobbe wrote: > On Thu, Apr 3, 2008 at 10:41 AM, David Jourard <davidj@bytesinteractive.com> > wrote: > >> Nathan Nobbe wrote: >> >>> how much code is there ? >>> >> 200 lines > > > i think ur safe posting that on the list directly. sometimes people post > several thousand lines and those sort of things are overlooked. > > I work alone and this is basically my first program. > > i drink alone ;) When I drink alone, I prefer to be by myself... > > I'm interested in feedback as to >> a. Am I using the variables correctly wrt global and local and passing by >> reference etc. >> b. Did I use the correct functions or are there better ones >> c. Security - of course >> d. Any suggestions on improving overall style. >> >> e. Is it ok to put the include file in the cgi-bin with my perl scripts. >> >> For many of you this is basic stuff probably but I want to make sure I'm >> getting it right. >> >> Note the login cookie is created by my perl script and the php program >> simply has to check that the user is logged in. > > > drop it in a post and well have a look. > > -nathan >