[php-src] PR #21910: Fix observer + JIT vm_interrupt
| From: | morrisonlevi | Date: | Wed, 29 Apr 2026 15:45:35 +0000 |
| Subject: | [php-src] PR #21910: Fix observer + JIT vm_interrupt | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-35949@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/21910
Author: morrisonlevi
We've been observing crashes in our customers' applications at Datadog for months with no
clear sign of _anything_ being wrong from the call stacks. Yesterday we finally got a key insight:
it's an interaction with the tracing JIT and VM interrupt. When the interrupt fires, the JIT
returns to the VM with a stale caller opline installed on the active callee execute_data, so the
interpreter resumes the caller’s call opcode against the wrong frame. It can happen on both x86_64
and aarch64.
The tell-tale sign was that the interpreter was executing one of the fcall family of opcodes where
EX(call) is unexpectedly NULL, and this JIT path was the only way that could happen.
This PR contains a reproducer for the issue. It modifies zend_test to set an interrupt function from
an observer_begin hoo; this is not strictly necessary, this is just the most reliable way I could
make the needed timing to trigger. I've made a jit.Dockerfile to accompany it:
<details>
<summary>Dockerfile for reproducing the JIT issue</summary>
```Dockerfile
# syntax=docker/dockerfile:1
# Build and run with the fix:
# docker build -f jit.Dockerfile -t php-src-8.4-jit-repro:fixed .
# docker run --rm php-src-8.4-jit-repro:fixed
#
# Build and run without the fix:
# docker build -f jit.Dockerfile --build-arg PHP_COMMIT=9613567fd892674eff0e2889099675de0a950c40
-t php-src-8.4-jit-repro:broken .
# docker run --rm php-src-8.4-jit-repro:broken
FROM debian:trixie
ENV DEBIAN_FRONTEND=noninteractive
RUN apt-get update \
&& apt-get install -y --no-install-recommends \
autoconf \
bison \
ca-certificates \
file \
g++ \
gcc \
git \
libc-dev \
libxml2-dev \
make \
pkg-config \
re2c \
&& rm -rf /var/lib/apt/lists/*
WORKDIR /usr/src
ARG PHP_REPO=https://github.com/morrisonlevi/php-src.git
ARG PHP_REF=observer_jit_vm_interrupt
RUN git init php-src \
&& cd php-src \
&& git remote add origin "$PHP_REPO" \
&& git fetch origin "$PHP_REF" \
&& git merge-base --is-ancestor "9613567fd892674eff0e2889099675de0a950c40"
FETCH_HEAD \
&& git checkout --detach "9613567fd892674eff0e2889099675de0a950c40"
WORKDIR /usr/src/php-src
# Pin the checkout so moving refs do not affect the repro.
ARG PHP_COMMIT=e28cf6a735aab0fe279cb89e9164b2a49a0e4eda
RUN if [ "$PHP_COMMIT" != "9613567fd892674eff0e2889099675de0a950c40" ]; then \
git merge-base --is-ancestor "$PHP_COMMIT" FETCH_HEAD && \
git checkout --detach "$PHP_COMMIT"; \
fi
RUN ./buildconf --force
RUN ./configure \
--prefix=/opt/php-src \
--disable-all \
--disable-cgi \
--disable-phpdbg \
--enable-cli \
--enable-opcache \
--enable-zend-test=shared
ARG MAKE_JOBS
RUN make -j"${MAKE_JOBS:-$(nproc)}"
RUN make install
ENV PATH="/opt/php-src/bin:${PATH}"
ENV TEST_PHP_EXECUTABLE=/opt/php-src/bin/php
ENV TEST_PHP_ARGS="-n -d zend_extension=opcache -d extension=zend_test"
CMD ["php", "run-tests.php", "-q",
"ext/zend_test/tests/observer_jit_vm_interrupt.phpt"]
```
</details>
As for the fix itself... I'm less confident in it. Please review it carefully as JIT code can
be tricky and I had an AI agent help me with it.