[php-src] PR #21912: Fix ext-dom shared build on Windows
| From: | iluuu1994 | Date: | Wed, 29 Apr 2026 22:38:06 +0000 |
| Subject: | [php-src] PR #21912: Fix ext-dom shared build on Windows | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-35950@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/21912
Author: iluuu1994
This was the result of an incorrect upmerge from PHP 8.4 into 8.5.
- Fix ADD_SOURCES() target parameter for lexbor sources
- Remove lexbor patches that were moved from ext/dom to ext/lexbor in 8.5.
Fixes GH-21911
I don't have a Windows machine to test, but nono's patch looks correct.
/cc @nono303 Thank you very much for the patch, and especially catching before the release.