[php-src] PR #25350: ext/dba: Fix dba_close() not closing a dba_popen() connection
| From: | iliaal | Date: | Mon, 09 Nov 2026 20:21:53 +0000 |
| Subject: | [php-src] PR #25350: ext/dba: Fix dba_close() not closing a dba_popen() connection | ||
| Groups: | php.git-pulls | ||
| Request: | Send a blank email to git-pulls+get-40478@lists.php.net to get a copy of this message | ||
Pull Request: https://github.com/php/php-src/pull/25350
Author: iliaal
After
dba_popen(), dba_close() left the file open and its lock held until
shutdown, because it looked up the persistent entry after dba_close_connection() had already cleared
connection->info. Count connections on the persistent resource's refcount again, as PHP 8.3
did, so the last dba_close() closes the handle. A handle sharing its stream with another persistent
handle (modes rl and rd on one file) stays open, as before. Lock checks also see persistent handles
still in use. Girgias pointed this out on #25155.