Re: Re[2]: [PHP-GTK-DEV] reduce compiler warnings (win32)

Hi Tom, Hrm.. rem rem Root of Visual C++ installed files. rem set MSVCDir=C:\PROGRA~1\MICROS~3\VC98 - is what goes into vcvars32.bat automatically, without me touching anything. How come you're needing to escape whitespace? If you need to add a path of your own you do something like: set MSDevDir=C:\sandbox SET PATH=C:\PROGRA~1\MICROS~3\VC98\BIN\;%MSDevDir%\BIN\;%MSDevDir%\php5\Release_ TS\;%PATH% (and similar with the lib and include paths) I couldn't get jscript's substr() to work here without the length parameter, apparently this is a known issue (not your fault, MS's). So it was adding an extra backslash to everything. Does the attached work for you? (and making your env vars sane paths?) ----- Original Message ----- From: "Tom Rogers" <trogers@kwikin.com> To: "Steph" <steph@zend.com> Cc: "PHP-GTK dev" <php-gtk-dev@lists.php.net>; "Andrei" <andrei@gravitonic.com> Sent: Sunday, September 11, 2005 9:53 AM Subject: Re[2]: [PHP-GTK-DEV] reduce compiler warnings (win32) > Hi, > > Sunday, September 11, 2005, 6:14:40 PM, you wrote: > S> S'funny, I was doing that last night too (and went the new-class-for-floats > S> route). > > S> We need to test both options - both get rid of compiler warnings. Yours is > S> prettier. > > S> The other two are code-related - need to check them with Andrei. > > Can you also check this change needed to compile using vc6 > > RCS file: /repository/php-gtk/win32/confutils.js,v > retrieving revision 1.5 > diff -u -w -b -r1.5 confutils.js > --- confutils.js 8 Sep 2005 03:19:44 -0000 1.5 > +++ confutils.js 11 Sep 2005 08:50:18 -0000 > @@ -392,7 +392,9 @@ > if (place == true) { > > place = exe; > > } else if (place != false) { > > + if(place.substr(-1) != "\\") place = place+"\\" > place = place + exe; > > + if(place.indexOf(' ')) place = '"'+place+'"'; > } > > > > if (place) { > > > -- > regards, > Tom > > -- > PHP-GTK Development Mailing List (http://gtk.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php >

Index: win32/confutils.js =================================================================== RCS file: /repository/php-gtk/win32/confutils.js,v retrieving revision 1.5 diff -u -r1.5 confutils.js --- win32/confutils.js 8 Sep 2005 03:19:44 -0000 1.5 +++ win32/confutils.js 11 Sep 2005 12:20:15 -0000 @@ -392,7 +392,13 @@ if (place == true) { place = exe; } else if (place != false) { + + if (place.lastIndexOf("\\") != place.length - 1) { + place += "\\"; + } + place = place + exe; + } if (place) {