PHP-GTK manual and demo scripts coding standards [WAS: Viewport critical warnings - sorted]

OK - since PEAR CS already exists and is well documented, it's probably better to go with that standard for demo/bug-test scripts than to create one of our own. (Forget the fact that I don't like it.) For anyone not already aware, the standard's online at http://pear.php.net/manual/en/standards.php. Items like Gtk::SELECTION_SINGLE really aren't pretty though - can we agree to have enums and flags upper cased throughout, as though they were constants? I don't like Gtk::main() either - I think functions without an object should be treated as standard PHP functions, i.e. lowercased. User-side functions and methods should be studlyCapped if we're sticking to the PEAR CS. I don't like that either, but it does at least make it very clear which functions belong to the user side and which to PHP-GTK itself. We're kind of mixed at present. Does anyone else have strong feelings about any style issues mentioned here? Also we need to decide where to put our Coding Standards file - should it be in php-gtk-doc or php-gtk module, or both? (Internals is easier, everyone that contributed already went with PHP's internal CS recommendations). - Steph ----- Original Message ----- From: "Christian Weiske" <cweiske@cweiske.de> To: "Steph Fox" <steph@zend.com> Cc: "PHP-GTK Dev list" <php-gtk-dev@lists.php.net> Sent: Monday, October 24, 2005 7:44 AM Subject: Re: [PHP-GTK-DEV] Viewport critical warnings - sorted > Steph, > > > > version hot from my desktop. Beware, we don't use the same CS - maybe we > > should decide on a set at some point? I notice Jeremy has a third way... > I use full PEAR CS. > > -- > Regards/MfG, > Christian Weiske