Re: PHP-GTK manual and demo scripts coding standards [WAS: Viewport critical warnings - sorted]
| From: | Christian Weiske | Date: | Mon, 24 Oct 2005 15:54:31 +0000 |
| Subject: | Re: PHP-GTK manual and demo scripts coding standards [WAS: Viewport critical warnings - sorted] | ||
| References: | 1 2 3 | Groups: | php.gtk.dev |
| Request: | Send a blank email to php-gtk-dev+get-1916@lists.php.net to get a copy of this message | ||
Steph,
> of our own. (Forget the fact that I don't like it.) For anyone not already
I had my problems as well, but now I'm adapted to it.
> Items like Gtk::SELECTION_SINGLE really aren't pretty though - can we agree
> to have enums and flags upper cased throughout, as though they were
> constants?
Yes, please.
> I don't like Gtk::main() either - I think functions without an object should
> be treated as standard PHP functions, i.e. lowercased.
So gtk::main()?
But then you *have* to do a gtk::SELECTION_SINGLE.
> User-side functions and methods should be studlyCapped if we're sticking to
> the PEAR CS. I don't like that either, but it does at least make it very
> clear which functions belong to the user side and which to PHP-GTK itself.
Yep.
> Also we need to decide where to put our Coding Standards file - should it be
> in php-gtk-doc or php-gtk module, or both?
php-gtk as the demos are there, and the doc people will know that the CS
are in the php-gtk module, or we make a link to that file.
> (Internals is easier, everyone that contributed already went with PHP's
> internal CS recommendations).
"Internals" refers to what?
--
Regards/MfG,
Christian Weiske