Re: Overrides for GtkUIManager and GtkCalendar

Tom, hi, Would you mind putting short test scripts in with your patches? It takes much longer to review things like this when I'm having to look through sources to figure out what the expected behaviour is and how to reproduce it via PHP... and I'd guess you tested it already, no? I'm really not sure about the date addition. I can see where you're coming from with the idea but it's a diversion from the target of language binding... and it's pretty trivial to produce that kind of a string from the data already available in GTK, with userland PHP code. Andrei, anyone - any strong feelings about it, either way? - Steph ----- Original Message ----- From: "Tom Rogers" <trogers@kwikin.com> To: <php-gtk-dev@lists.php.net> Sent: Saturday, December 10, 2005 7:28 AM Subject: [PHP-GTK-DEV] Overrides for GtkUIManager and GtkCalendar

Hi Here is a combined UiManager and GtkCalendar patch for gtk2 I have added a fourth value to the array returned by GtkCalendar::get_date() which is a string suitable for use in the php strtotime() function (ie. '2005-12-10') The month I have left in the 0-11 format to match the rest of the calendar functions. The UiMangager functions I provided before were missing NOT_STATIC_METHOD(); Hope this helps. -- Tom

--------------------------------------------------------------------------------

-- PHP-GTK Development Mailing List (http://gtk.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php