Re: GdkPixbufFormat struct

Christian Weiske wrote:

Hello all, Andrei, xxoes is about to implement

GdkPixbuf::pixbuf_get_file_info($filename,&$width,&$height);

it returns a GdkPixbufFormat. He thought it would be the most easy thing to return an associative array with all the values, and additional to the struct keys, return width and height in the same array. Is that ok? Would it be better to make an own class for GdkPixbufFormat?

If you return an array, you will have to define a bunch of constants for the array keys in order to make everyone's life easier. You can't expect everyone to just remember that the third element is the domain, but you can expect them to remember they can get the domain with $pixbufFormat[Gdk::PIXBUF_FORMAT_DOMAIN]. If the GdkPixbuf::format_* methods are already implemented it might just be easier to keep the current functionality. It would mean less development and testing. -- Scott Mattocks http://www.crisscott.com