Re: patch: GtkRecentChoserDialog::__construct complete

Bob should apply for a CVS account first.

Applied.

A couple of things about the patch:

O.K. It was mostly copy paste from GtkDialog::add_with_buttons(). Should I fix that one as well? -- Bob Majdak Jr KateOS Rofflecopter Pilot http://www.kateos.org Andrei Zmievski wrote:

Bob should apply for a CVS account first. A couple of things about the patch: Let's start using php_error_docref() instead of php_error() since we automatically get class/method name that way. php_error(

+                E_WARNING,
+                "%s::%s(): button list has to contain pairs of items",
+                get_active_class_name(NULL TSRMLS_CC),
+                get_active_function_name(TSRMLS_C)
+            );

turns into php_error_docref(NULL TSRMLS_CC, E_WARNING, "button list has to contain pairs of items")); Also, the creation of the wrapped object should be delayed until all the other checks are done. That way we avoid gtk_object_destroy() and all that stuff. -Andrei Bob Majdak Jr wrote:

From gen_gtk.log: constructor GtkRecentChooserDialog::__construct: varargs methods not supported This patch completes the GtkRecentChooserDialog::__construct(). Works the same way GtkDialog::new_with_buttons() works except no flags parametre. screenshot of it: http://www.opsat.net/temp/rcdcon.jpg gtk_recent_chooser_dialog_new(

    const gchar *title,
    GtkWindow *parent,
    const gchar *first_button_text,
    ...

); GtkRecentChooserDialog::__construct(

    string title,
    GtkWindow parent,
    array(string label, int response, ...)

);