Re: patch: GtkRecentChoserDialog::__construct complete
| From: | Bob Majdak Jr | Date: | Mon, 05 Nov 2007 21:51:00 +0000 |
| Subject: | Re: patch: GtkRecentChoserDialog::__construct complete | ||
| References: | 1 2 3 4 | Groups: | php.gtk.dev |
| Request: | Send a blank email to php-gtk-dev+get-4007@lists.php.net to get a copy of this message | ||
Thoughts? Should invalid date be fatal too? Should the inability to count be non-fatal?
+ updated patch.
-------------------
//. good
$w = new GtkRecentChooserDialog(
'The Dialog, LOL', null,
array(
Gtk::STOCK_CANCEL,Gtk::RESPONSE_CANCEL,
Gtk::STOCK_OK,Gtk::RESPONSE_OK
)
);
-------------------
// fatal because you fail at counting.
$w = new GtkRecentChooserDialog(
'The Dialog, LOL', null,
array(
Gtk::STOCK_CANCEL,Gtk::RESPONSE_CANCEL,
Gtk::STOCK_OK
)
);
Fatal error: GtkRecentChooserDialog::__construct(): button list has to contain pairs of items in recentchooserdialog-construct.phpg on line 10
-------------------
// warning because you fail at listening and to get even
// the ok button shall be skipped. hah on you!
$w = new GtkRecentChooserDialog(
'The Dialog, LOL', null,
array(
Gtk::STOCK_CANCEL,Gtk::RESPONSE_CANCEL,
Gtk::STOCK_OK,'omgomgomg'
)
);
Warning: GtkRecentChooserDialog::__construct(): each pair in button list is to be string/integer in recentchooserdialog-construct.phpg on line 10
-------------------
--
Bob Majdak Jr
KateOS Rofflecopter Pilot
http://www.kateos.org
Anant Narayanan wrote:
Bob Majdak Jr wrote:O.K. It was mostly copy paste from GtkDialog::add_with_buttons(). Should I fix that one as well?php_error is used extensively throughout the code (counting the extensions), we might want to start replacing all of the instances where the class name is required with php_error_docref. -- Anant
Attachment: [text/x-patch] gtkrecentchooser-construct-bob20070511a.diff