#50889 [NEW]: Patch-Request: Fixes to confutils.js

From: thomas dot worm at thomas-worm dot de Operating system: Windows PHP version: 5.3.1 PHP Bug Type: PHP-GTK related Bug description: Patch-Request: Fixes to confutils.js Description: ------------ - If php-gtk is compiled without extensions configure.js will run into an error because MFE is completely empty. - Sometimes configure.js doesn't write !ENDIF although !IF is always written. So make isn't able to parse the Makefile This can be fixed with following patch: diff -Nur php-gtk.orig/win32/confutils.js php-gtk/win32/confutils.js --- php-gtk.orig/win32/confutils.js 2010-01-16 19:02:31.068819700 +0100 +++ php-gtk/win32/confutils.js 2010-01-16 20:08:36.402623800 +0100 @@ -991,6 +991,7 @@ function generate_makefile() { + MFE.WriteLine(""); // To avoid error if MFE will be complete empty MFE.Close(); // Makefile.extensions is now complete MFO.Close(); // Makefile.objects is now complete var MF = FSO.CreateTextFile("Makefile", true); @@ -1022,8 +1023,8 @@ if (make_builds.length > 1) { MF.WriteLine("!ELSE"); MF.WriteLine("!MESSAGE Note: $(PHPGTKLIB) must be created before PHP-GTK extensions can be built"); - MF.WriteLine("!ENDIF"); } + MF.WriteLine("!ENDIF"); MF.WriteLine("build_dirs: $(BUILD_DIR) $(BUILD_DIRS_SUB)"); MF.WriteBlankLines(1); Reproduce code: --------------- cscript /nologo configure.js Expected result: ---------------- configure.js runs well nmake is executed Actual result: -------------- configure.js crashed when MFE is completely empty nmake isn't able to read Makefile -- Edit bug report at http://bugs.php.net/?id=50889&edit=1 -- Try a snapshot (PHP 5.2): http://bugs.php.net/fix.php?id=50889&r=trysnapshot52 Try a snapshot (PHP 5.3): http://bugs.php.net/fix.php?id=50889&r=trysnapshot53 Try a snapshot (PHP 6.0): http://bugs.php.net/fix.php?id=50889&r=trysnapshot60 Fixed in SVN: http://bugs.php.net/fix.php?id=50889&r=fixed Fixed in SVN and need be documented: http://bugs.php.net/fix.php?id=50889&r=needdocs Fixed in release: http://bugs.php.net/fix.php?id=50889&r=alreadyfixed Need backtrace: http://bugs.php.net/fix.php?id=50889&r=needtrace Need Reproduce Script: http://bugs.php.net/fix.php?id=50889&r=needscript Try newer version: http://bugs.php.net/fix.php?id=50889&r=oldversion Not developer issue: http://bugs.php.net/fix.php?id=50889&r=support Expected behavior: http://bugs.php.net/fix.php?id=50889&r=notwrong Not enough info: http://bugs.php.net/fix.php?id=50889&r=notenoughinfo Submitted twice: http://bugs.php.net/fix.php?id=50889&r=submittedtwice register_globals: http://bugs.php.net/fix.php?id=50889&r=globals PHP 4 support discontinued: http://bugs.php.net/fix.php?id=50889&r=php4 Daylight Savings: http://bugs.php.net/fix.php?id=50889&r=dst IIS Stability: http://bugs.php.net/fix.php?id=50889&r=isapi Install GNU Sed: http://bugs.php.net/fix.php?id=50889&r=gnused Floating point limitations: http://bugs.php.net/fix.php?id=50889&r=float No Zend Extensions: http://bugs.php.net/fix.php?id=50889&r=nozend MySQL Configuration Error: http://bugs.php.net/fix.php?id=50889&r=mysqlcfg