#50889 [Opn->Asn]: Patch-Request: Fixes to confutils.js

ID: 50889 Updated by: felipe@php.net Reported By: thomas dot worm at thomas-worm dot de -Status: Open +Status: Assigned Bug Type: PHP-GTK related Operating System: Windows PHP Version: 5.3.1 -Assigned To: +Assigned To: auroraeosrose Previous Comments: ------------------------------------------------------------------------ [2010-01-30 21:20:46] thomas dot worm at thomas-worm dot de Description: ------------ - If php-gtk is compiled without extensions configure.js will run into an error because MFE is completely empty. - Sometimes configure.js doesn't write !ENDIF although !IF is always written. So make isn't able to parse the Makefile This can be fixed with following patch: diff -Nur php-gtk.orig/win32/confutils.js php-gtk/win32/confutils.js --- php-gtk.orig/win32/confutils.js 2010-01-16 19:02:31.068819700 +0100 +++ php-gtk/win32/confutils.js 2010-01-16 20:08:36.402623800 +0100 @@ -991,6 +991,7 @@ function generate_makefile() { + MFE.WriteLine(""); // To avoid error if MFE will be complete empty MFE.Close(); // Makefile.extensions is now complete MFO.Close(); // Makefile.objects is now complete var MF = FSO.CreateTextFile("Makefile", true); @@ -1022,8 +1023,8 @@ if (make_builds.length > 1) { MF.WriteLine("!ELSE"); MF.WriteLine("!MESSAGE Note: $(PHPGTKLIB) must be created before PHP-GTK extensions can be built"); - MF.WriteLine("!ENDIF"); } + MF.WriteLine("!ENDIF"); MF.WriteLine("build_dirs: $(BUILD_DIR) $(BUILD_DIRS_SUB)"); MF.WriteBlankLines(1); Reproduce code: --------------- cscript /nologo configure.js Expected result: ---------------- configure.js runs well nmake is executed Actual result: -------------- configure.js crashed when MFE is completely empty nmake isn't able to read Makefile ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=50889&edit=1