Re: LDAP controls support API [Question for the RM at the end]

On Wed, Jul 26, 2017 at 12:11 PM, Côme Chilliet <come@opensides.be> wrote: > As ldap_exop was merged in 7.2, is it possible to have a BC on it for 7.3 or not? > It would be by adding options in the middle: > resource ldap_exop(resource link, string reqoid [, > string reqdata [, array servercontrols [, array clientcontrols [, > string retdata [, string retoid]]]]]) > I'll be honest, the code in this function looks bizarre to my eyes (perhaps because I've been in C++14 land lately), but it's your code and you have the context in mind for it. The current return value for 4 or more args is simply true, so the BC break would be trivial to make that a resource (which evaluates as true), but I think we can make that even simpler. Just fix it before beta3 (or beta2 if the fix is already ready) and I won't tell on you to Remi. -Sara