Re: LDAP controls support API [Question for the RM at the end]
| From: | Côme Chilliet | Date: | Thu, 27 Jul 2017 08:21:59 +0000 |
| Subject: | Re: LDAP controls support API [Question for the RM at the end] | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-100056@lists.php.net to get a copy of this message | ||
Le mercredi 26 juillet 2017, 12:48:04 CEST Sara Golemon a écrit :
> The current return value for 4 or more args is simply
Attachment: [text/x-patch] 0001-Added-controls-parameters-to-ldap_exop-so-that-contr.patch
true, so
> the
> BC break would be trivial to make that a resource (which evaluates as
> true), but I think we can make that even simpler. Just fix it before
> beta3 (or beta2 if the fix is already ready) and I won't tell on you
> to Remi.
So how about the patch attached?
I did not include your suggested changes as I did not manage to make it work for now, plus this will
have to be changed for all functions so I’d prefer to work on this clean up after I get back from
holidays at the end of August.
But thanks for the suggested changes, ext/ldap code does need more set of eyes looking at it and I
do not master PHP internal features yet.
Côme
Attachment: [text/x-patch] 0001-Added-controls-parameters-to-ldap_exop-so-that-contr.patch