Re: Apply substr() optimization to array_slice()
| From: | Sara Golemon | Date: | Fri, 27 Oct 2017 14:16:42 +0000 |
| Subject: | Re: Apply substr() optimization to array_slice() | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-100968@lists.php.net to get a copy of this message | ||
On Fri, Oct 27, 2017 at 8:12 AM, Benjamin Coutu <ben.coutu@zeyos.com> wrote:
> Now, array_slice() could be optimized similarly, but currently
> (unless the resulting array is expected to be empty) we always
> create a new array no matter if we actually have to.
>
Pushed, with an additional escape hatch for vector-like arrays (which
are implicitly like preserve_keys). In the future though, please use
the PR process. Thanks.
-Sara