Re: Apply substr() optimization to array_slice()
| From: | Nikita Popov | Date: | Mon, 30 Oct 2017 15:17:48 +0000 |
| Subject: | Re: Apply substr() optimization to array_slice() | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-100994@lists.php.net to get a copy of this message | ||
On Mon, Oct 30, 2017 at 4:09 PM, Sara Golemon <pollita@php.net> wrote:
> On Mon, Oct 30, 2017 at 6:51 AM, Dmitry Stogov <dmitry@zend.com> wrote:
> > The optimization also broke Zend/tests/bug72598.phpt and
> Zend/tests/bug72598_2.phpt
> >
> Damn. I had a feeling references would rear their ugly head here.
>
> Fuggit, reverted. We can take another swing at it later, but it's not
> a vital optimization.
>
> -Sara
>
This is really more of a bug in call_user_func_array(). It should be
treating rc=1 references as non-references and throw a warning in that case
as well. That may not be very popular behavior though...
Nikita