Re: Consistent indentation for test files

On Sun, 29 Oct 2017, Jakub Zelenka wrote: > On Sat, Oct 28, 2017 at 12:59 PM, Nikita Popov <nikita.ppv@gmail.com> wrote: <snip> > > Here are the current statistics for code in .phpt files: > > > > total: 15515 > > prefer tabs: 4273 (27.5%) > > prefer spaces: 6307 (40.7%) > > draw: 77 (0.5%) > > no indentation: 4858 (31.3%) > > > > There are 1824 (11.8%) files that contain mixed tab and space indentation. > > The indentation was determined based on the first character of a line. > > > > I would like to propose that we establish a common standard by > > a) using space indentation for all future tests (as they currently form the > > majority), and > > I usually use tabs for phpt as it's a bit simpler with my IDE that I use > for PHP core dev (QtCreator) and mostly the core exts that I work with had > tabs. That said I wouldn't be against making it the same and use spaces > everywhere if we also start using PSR-2 for tests - it's not just an > indentation that is a mess... > > > b) reindenting existing test files to use space indentation. > > > +1 but it needs to be done in the lowest active branch otherwise it will > result in conflicts when changing existing tests (it is sometimes useful > for extending tests)... I'm -1 on the whole exercise, but this comment by Jakub is what worries me most. cheers, Derick -- https://derickrethans.nl | https://xdebug.org | https://dram.io Like Xdebug? Consider a donation: https://xdebug.org/donate.php twitter: @derickr and @xdebug