Re: net_get_interfaces()

On 27.11.2017 12:15, Dan Ackroyd wrote: > On 26 November 2017 at 16:28, Florian Anderiasch <ml@anderiasch.de> wrote: > >> if this simply doesn't work on some OSes for >> no good reason.. that's a pretty leaky abstraction. > > Cool. Does that mean that we can drop support for 32bit builds if > leaky abstractions are an important thing? If someone commits something that only works on 64bit and wasn't tested a single time on a 32 bit machine - yes. >> Looks good in theory, but without a lot of thought, how likely is this >> to break/work on "supported" operating systems? > > It's likely to work on platforms that have the C functions > implemented. Which is the level of guarantee that PHP aims for; "If > the platform implements a feature, PHP will expose it, but won't > always go out of its way to work around missing features". Yes, I wrote that it's likely. Maybe I just didn't make myself clear enough that I see a *slight* difference between something that's relatively nicely encapsulated in the language itself versus something that not only depends on some C headers, but maybe the whole network stack of the OS. >> just because there's one year of time and "we have no CI for that" is >> not a good excuse in my book. > > If this is important to you, please step up and do something about it. > > If it is only of just enough importance to you that you send an email > to this list, asking other people to do a shedload of work to satisfy > your vague feelings, then as Sara said, committing it now gives people > a whole year to find issues with it, and then we can take action > against known issues, rather than worrying about unknown unknowns. I didn't ask anybody to to any work. I saw this as a call for comments, and Sara kind of addressed my *concerns* where I said I *think* this *might* break. Also I'm really sorry that I disappointed you by not managing to finish testing on OpenBSD (which I actually started just before seeing this mail) and I already sent some results for FreeBSD yesterday, which showed a tiny issue. Insert friendly suggestion to not throw stones when lingering near breakable structures. Greetings, Florian