Re: net_get_interfaces()

On 27.11.2017 16:38, Sara Golemon wrote: > On Mon, Nov 27, 2017 at 10:34 AM, Florian Anderiasch <ml@anderiasch.de> wrote: >> Also I'm really sorry that I disappointed you by not managing to finish >> testing on OpenBSD (which I actually started just before seeing this >> mail) and I already sent some results for FreeBSD yesterday, which >> showed a tiny issue. >> > Yes! I saw that! Thank you. It wasn't so much a BSD issue as the fact > you did a bare build, while my default build happens to include the > sockets extension (which provides the AF_INET constant I was using in > the unit test). Thanks to your testing, I was able to refactor the > test slightly to not require ext/sockets be enabled in order to work. > :D > > -Sara > No worries, nothing in that was directed at you, Sara. (But not sure if having to enable sockets proves my point or not, I guess it did provide at least some value). Good news: master after the merge works on OpenBSD, once the build is fixed. Somehow it doesn't match the +#if HAVE_NET_IF_H in net.c I had to unconditionally include it (for testing), otherwise IFF_BROADCAST and IFF_POINTOPOINT are undefined. (they are in sys/net/if.h on OpenBSD, but I only tested 6.2). Can do a proper bug report if needed, but maybe I get around to test NetBSD as well. Greetings, Florian