Re: Re: PHP 7.3 zif_handler changes
| From: | Christoph M. Becker | Date: | Thu, 28 Jun 2018 10:56:43 +0000 |
| Subject: | Re: Re: PHP 7.3 zif_handler changes | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-102511@lists.php.net to get a copy of this message | ||
On 28.06.2018 at 06:22, Xinchen Hui wrote:
> FAST_CALL should only affects win32. and it can bring some improvement in
> win32..
>
> People should use zif_handler instead of define there own from now on, I
> think documented it in UPGRADING is enough....
Thanks! I've pushed
<http://git.php.net/?p=php-src.git;a=commit;h=2ff26bdf7370fff79d743c390e23cd9f477c855d>.
Please have a look at
<https://github.com/m6w6/ext-http/commit/377d576a6e68def5708cf1ffcd3c233c4dddf356>.
Apparently, zval_ptr_dtor() had to be replaced with
zval_internal_dtor() to avoid a segfault with PHP 7.3. Is this caused
by a change in the engine? If so, is this change documented?
--
Christoph M. Becker