Re: [RFC] [VOTE] Class Friendship

From: Date: Mon, 09 Jul 2018 14:32:59 +0000
Subject: Re: [RFC] [VOTE] Class Friendship
References: 1 2  Groups: php.internals 
Request: Send a blank email to internals+get-102664@lists.php.net to get a copy of this message
On Sat, Jul 7, 2018 at 6:46 PM Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: > > I would like to vote to "yes". > However, RFC does not have benchmark result. Do you have some results? > > Regards, > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net > Yasuo, I have documented a benchmark based on my last comment. This benchmark could be improved through larger sample size but it looks like there is little to no difference in performance between the two. The result I determined with a sample size of 100N was a 0.000425905 second difference between master and feature/friend-classes-poc (friend branch was slower by that delta). My experiment is documented at https://gist.github.com/mdwheele/e4dce7adb7a4f523011c21de6b29f001. Thanks, -- Dustin Wheeler | Software Developer NC State University mdwheele@ncsu.edu "If you don't know where you're going, it's easy to iteratively not get there."

« previous php.internals (#102664) next »