Re: libmbfl API changes in PHP 7.3

On 10.07.2018 at 10:30, Jan Ehrhardt wrote: > While trying to make the mailparse extension fit for PHP 7.3 I ran into > changes in the libmbfl API. I cannot find any documentation on this > change. > > The change was introduced in this commit by nikic: > > https://github.com/php/php-src/commit/b3c1d9d1118438a3dae3544447db2b39ca5cfa25 > > To be specific: > > https://github.com/php/php-src/commit/b3c1d9d1118438a3dae3544447db2b39ca5cfa25#diff-929fd74a8732776fa8776939a9b907d4L71 > > It broke the code of the mailparse extension at this line: > > https://github.com/php/pecl-mail-mailparse/blob/master/php_mailparse_mime.c#L910 > > Shouldn't the be documented? And/or is there an easy fix? Have you tried to convert the first two arguments via mbfl_no2encoding()[1]? Anyhow, it seems to me that we should document why “--with-libmbfl is no longer available” (UPGRADING); because the bundled libmfl is now mandatory, since it has been changed, and at least to superficially add some respective notes to UPGRADING.INTERNALS. [1] <https://github.com/php/php-src/blob/php-7.3.0alpha3/ext/mbstring/libmbfl/mbfl/mbfl_encoding.c#L271-L285> -- Christoph M. Becker