Re: libmbfl API changes in PHP 7.3
| From: | Jan Ehrhardt | Date: | Tue, 10 Jul 2018 13:39:39 +0000 |
| Subject: | Re: libmbfl API changes in PHP 7.3 | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-102710@lists.php.net to get a copy of this message | ||
"Christoph M. Becker" in php.internals (Tue, 10 Jul 2018 12:04:10
+0200):
>Have you tried to convert the first two arguments via mbfl_no2encoding()[1]?
It compiles, but segfaults in 1 test on this line
https://github.com/php/pecl-mail-mailparse/blob/master/mailparse.c#L1466
Unhandled exception at 0x000007FEEC6E83C2 (php7.dll) in php.exe:
0xC0000005: Access violation reading location 0x000000060BE02800.
occurred
Relevant part of the backtrace:
[Inline Frame] php7.dll!zend_mm_alloc_small(_zend_mm_heap *) Line 1285
[Inline Frame] php7.dll!zend_mm_alloc_heap(_zend_mm_heap * heap,
unsigned __int64) Line 1356
php7.dll!_emalloc(unsigned __int64 size) Line 2496
[Inline Frame] php_mailparse.dll!zend_string_alloc(unsigned __int64)
Line 133
[Inline Frame] php_mailparse.dll!zend_string_init(const char *) Line 155
php_mailparse.dll!mailparse_get_part_data(_php_mimepart * part,
_zval_struct * return_value)
It passes all tests in PHP 7.2.8 RC1.
I will make a PR and continue the discussion there.
--
Jan