Re: RFC Proposal: Make the hash extension always available
| From: | Christoph M. Becker | Date: | Tue, 04 Sep 2018 10:20:25 +0000 |
| Subject: | Re: RFC Proposal: Make the hash extension always available | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-103121@lists.php.net to get a copy of this message | ||
On 04.09.2018 at 11:11, Kalle Sommer Nielsen wrote:
> I just posted an RFC and set it up for discussion[1], this proposes to
> make the ext/hash extension always enabled, similar to that for date,
> spl & pcre.
>
> Comments are welcome. I intend to start voting in 2-3 weeks time,
> should there be no critical issues in regards to this RFC.
>
>
> [1] https://wiki.php.net/rfc/permanent_hash_ext
That appears to be sensible. Anyhow, *if* we do this, we also should
move the MD5, SHA1 and CRC32 code from ext/standard to ext/hash (MD5 and
SHA1 is currently dead code in ext/hash, and the CRC32 implementation
seems to be duplicated). We should also have a look at crypt_sha256.c
and crypt_sha512.c (of ext/standard) which likely duplicate some code
already available in ext/hash.
--
Christoph M. Becker