Re: RFC Proposal: Make the hash extension always available
| From: | Kalle Sommer Nielsen | Date: | Tue, 04 Sep 2018 10:38:28 +0000 |
| Subject: | Re: RFC Proposal: Make the hash extension always available | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-103122@lists.php.net to get a copy of this message | ||
Den tir. 4. sep. 2018 kl. 12.20 skrev Christoph M. Becker <cmbecker69@gmx.de>:
> That appears to be sensible. Anyhow, *if* we do this, we also should
> move the MD5, SHA1 and CRC32 code from ext/standard to ext/hash (MD5 and
> SHA1 is currently dead code in ext/hash, and the CRC32 implementation
> seems to be duplicated). We should also have a look at crypt_sha256.c
> and crypt_sha512.c (of ext/standard) which likely duplicate some code
> already available in ext/hash.
Those makes a lot of sense to do, and definitely something we should
if this RFC passes
--
regards,
Kalle Sommer Nielsen
kalle@php.net