Re: Unbundle libsqlite3?

Hi Den man. 17. sep. 2018 kl. 15.16 skrev Christoph M. Becker <cmbecker69@gmx.de>: > > Hi! > > We bundle an unmodified libsqlite3 for at least two years. Since then > all updates go into any dev, alpha and beta releases, while security > patches (usually backports from libsqlite3) go into stable branches. > > ext/sqlite3 requires libsqlite ≥ 3.3.9[1] which has been released on > 2007-01-04[2] (i.e. more than eleven years ago!). ext/pdo_sqlite has no > specific version requirement; there is a check for sqlite3_open()[3] > which I believe is available since 3.0.0. > > So is there any particular reason why we still bundle libsqlite3? > > [1] > > <https://github.com/php/php-src/blob/php-7.3.0RC1/ext/sqlite3/config0.m4#L37-L47> > [2] <https://sqlite.org/oldnews.html#2007_01_04> > [3] > > <https://github.com/php/php-src/blob/php-7.3.0RC1/ext/pdo_sqlite/config.m4#L55-L58šÛÒ¦$ > ‘nuà³-ÊabÁ> I don't think there is any paticular reason for bundling it anymore, at least not from the Windows side of things where we should be easily able to adapt the build system to link to it instead of building the bundled version. (Anatol cc'ed) -- regards, Kalle Sommer Nielsen kalle@php.net