Re: Unbundle libsqlite3?
| From: | BohwaZ | Date: | Wed, 19 Sep 2018 17:57:19 +0000 |
| Subject: | Re: Unbundle libsqlite3? | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-103185@lists.php.net to get a copy of this message | ||
On Wed, 19 Sep 2018 19:41:11 +0200 / "Christoph M. Becker"
<cmbecker69@gmx.de> said :
> PR #2698[2] seems to require an RFC. IMHO, it's best to present RFCs
> and voting on them as early as possible (instead of rushing them at
> the last moment). :)
Yeah there was an RFC and it was voted no:
https://wiki.php.net/rfc/implement_sqlite_openblob_in_pdo
Discussion was that current PDO way of handling DB-specific features is
not the best. Unfortunately no one volunteered to change that fact, and
as my patch wasn't approved PDO_SQLite is still behind SQLite3 and
missing features.
I was actually talking about https://github.com/php/php-src/pull/2760
which was approved just after feature freeze of PHP 7.3.
> I agree that an exception would be better. A sensible alternative
> might be to not even include the method for older libsqlite3. Either
> way, a PR targeting master would be welcome.
Yeah unfortunately due to the result of the previous RFC I stopped my
efforts trying to bring up pdo_sqlite and SQLite3 up to date. I have
very little free time, so spending it for useless patches is not the
best use of it, sorry.