Re: [RFC][Vote] Covariant Returns and ContravariantParameters
| From: | Christoph M. Becker | Date: | Thu, 20 Dec 2018 23:14:25 +0000 |
| Subject: | Re: [RFC][Vote] Covariant Returns and ContravariantParameters | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-103617@lists.php.net to get a copy of this message | ||
On 20.12.2018 at 23:35, Dmitry Stogov wrote:
> It looks like the patch broke something related to opcache.
>
> It crashes at least on Wordpress and Drupal.
Note that <https://bugs.php.net/76937> is still
unresolved – apparently
a regression from PHP 7.2. The testing code that triggered the problem
is still commented out[1].
> Inability to work with opcache, doesn't allow to check the performance impact.
I agree that we should carefully check the performance impact of the
proposed change.
[1]
<https://github.com/drupal/drupal/blob/8.6.x/core/tests/Drupal/KernelTests/Core/Entity/EntityQueryTest.php#L141-L144>
--
Christoph M. Becker