Re: [RFC][Vote] Covariant Returns and ContravariantParameters

On 24.12.2018 at 13:20, Dmitry Stogov wrote: > - The patch is incompatible with opcache (crashes on Wordpress, Drupal, and probably any > real-life app). > > - the incompatibility with opcache, doesn't allow to check the performance implication of > the patch > > - the patch has merge conflicts and travis tests doesn't run. > > > Personally, I'm not against the proposal, but I'm definitely against this > implementation. > > Probably, it's better to cancel the voting and restart when the implementation is ready. > > > It's pity to see, that nobody tries the implementation but blindly vote... Well, one may argue that the voting is about the concept, but not about a (preliminary) implementation. The main concern, in my opinion, is rather whether it is possible to implement the proposal without (much) drawbacks (such as general performance regression). A working patch would be helpful to prevent cases where we accept a proposal, but later face difficulties implementing it and/or can't agree on some of the details[1][2]. We may consider to augment the RFC process to clearly require a working implementation before starting the vote. [1] <https://wiki.php.net/rfc/null_coalesce_equal_operator> [2] <https://wiki.php.net/rfc/notice-for-non-valid-array-container> -- Christoph M. Becker