Re: Remove zpp variation tests

Em qua, 30 de jan de 2019 às 07:46, Nikita Popov <nikita.ppv@gmail.com> escreveu: > Hi internals, > > We currently have a large number of zpp "variation" tests, which > essentially only test the behavior of zend_parse_parameters plugged into > different functions. A random example of such a test: > > > > https://github.com/php/php-src/blob/master/ext/standard/tests/strings/addslashes_variation1.phpt > > This test passes a certain set of input values of different types to a > function with a zpp string argument and observes the behavior. Of course, > there are also hundreds of other functions that accept strings through zpp > and the behavior is always going to be the same. > > Based on a quick grep I would estimate that we have around 700 of these > tests. We have a hard policy against adding new tests for zpp behavior, but > I would like to get rid of the existing ones as well. They provide > essentially no value, but are a major chore to update for even for minor > changes. > > Regards, > Nikita > Yes, yes, yes! When I was implementing the https://github.com/php/php-src/pull/3429, was a pain fixing all those tests. -- Gabriel Caruso