Re: Remove zpp variation tests
| From: | Stanislav Malyshev | Date: | Wed, 30 Jan 2019 18:39:45 +0000 |
| Subject: | Re: Remove zpp variation tests | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-103900@lists.php.net to get a copy of this message | ||
Hi!
> This test passes a certain set of input values of different types to a
> function with a zpp string argument and observes the behavior. Of course,
> there are also hundreds of other functions that accept strings through zpp
> and the behavior is always going to be the same.
This is true for functions that use standard zpp handling, but there are
a number of them that use custom zpp handling, and for those there could
be corner cases which aren't handled properly. In fact, I've seen some
zpp-using functions that so not properly handle nulls, empty strings,
etc. as arguments (zpp works fine, it's the part past zpp that fails).
So we need to be careful and remove only those tests that are indeed
handled by zpp and not the code beyond it that does need to be tested,
and not remove tests which cover custom argument handling.
--
Stas Malyshev
smalyshev@gmail.com