Re: 2016 TestFest, did the tests written then ever get merged?

From: Date: Thu, 07 Feb 2019 15:14:28 +0000
Subject: Re: 2016 TestFest, did the tests written then ever get merged?
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to internals+get-104291@lists.php.net to get a copy of this message
On Wed, Feb 6, 2019 at 4:14 PM Ben Ramsey <ben@benramsey.com> wrote: > > On Feb 6, 2019, at 01:22, Peter Kokot <peterkokot@gmail.com> wrote: > > I can help sort this mess. A separate fork out of the php/php-src was > > not such a good idea. > > Sorry. I made many poor decisions around how I managed that entire event. > It’s my own personal Fyre Festival. :-( > > I’m happy to help in any way I can to get these ready to merge into > php-src. Let me know how I can help. > > -Ben > anyone with access to the php-src git repo should be able to merge them pretty easily; it's a matter of running: curl -s ' https://github.com/phpcommunity/phptestfest-php-src/pulls?page=1&q=is%3Apr+is%3Aopen+review%3Aapproved'|grep -Po '(?<=<div id="issue_)[0-9]*'|while read id do curl https://patch-diff.githubusercontent.com/raw/phpcommunity/phptestfest-php-src/pull/$id.patch|git am done and increase the page-number in the first URL to includes pages 2 & 3 as well. Run this in your checkout (possibly on a branch) and push that to github

« previous php.internals (#104291) next »