Re: 2016 TestFest, did the tests written then ever get merged?

Em sáb, 9 de fev de 2019 às 06:08, Mark Baker <mark@lange.demon.co.uk> escreveu: > On 06/02/2019 08:13, Mark Baker wrote: > > Looking at the Voting Eligibility discussion going on at the moment. > > > > I, like many others, participated in the last testfest 18 months or so > > ago. Did the results from that ever get merged? Or have they simply been > > discarded or forgotten? If merged, they certainly don't show up in the > > contributions list posted aganst the Workflow and Voting RFC Eligibility > > list: yet all those who participated in the testfest care about the > > language enough to get involved > > > > > Thank you. It's good to see merging has started. I appreciate your work, > as I'm sure will many of those who contributed through the TestFest > > > -- > Mark Baker > > _________ > |. \ \-3 > |_J_/ PHP | > || | __ | > || |m| |m| > > I LOVE PHP > > Hello everyone. I've reviewed a couple of those PRs, closing some ZPP Failures tests and duplicated ones and now we have 94 to go. Some of them I've left a comment to adjust the test to get merge, others, I'm not familiar with the extension/function/test to approve. If someone wants to take a look and help us finish this task, I'd appreciated it :) https://github.com/phpcommunity/phptestfest-php-src/pulls Best, -- Gabriel Caruso