Re: Re: Don't silence fatal errors
| From: | Nikita Popov | Date: | Mon, 11 Feb 2019 15:23:35 +0000 |
| Subject: | Re: Re: Don't silence fatal errors | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-104341@lists.php.net to get a copy of this message | ||
On Wed, Feb 6, 2019 at 10:45 PM Christoph M. Becker <cmbecker69@gmx.de>
wrote:
> On 06.02.2019 at 05:42, Zeev Suraski wrote:
>
> > As long as we have a prominent warning about this in our migration guide
> > alerting people to the associated risk in setups where display errors is
> on
> > - I can live with the change as-is. How do we ensure that it doesn't get
> > lost in the clutter given that it has no RFC?
>
> Generally, *everything* that needs to be mentionend in the migration
> guide, should have a respective entry in UPGRADING. That makes creating
> the migration guide straight forward for the doc team, and worked quite
> well for PHP 7.3 at least.
>
As the discussion here has drifted off towards error handling in general
and there hasn't been any further input on the change itself, I've gone
ahead and committed this:
https://github.com/php/php-src/commit/a302d1161036988fe220ecd8ecd73e6af1a116fc
I've also included a few UPGRADING notes.
Nikita